search

ORNL / DataFed

A Federated Scientific Data Management System
https://ornl.github.io/DataFed/
Other
18 stars 14 forks source link

Web - Update provenance graph after references are edited #417

Closed dvstans closed 4 years ago

dvstans commented 4 years ago

If the provenance of a record is edited, the currently displayed provenance graph must be updated if these changes affect it. For example, edges could be added or removed between existing nodes, or entire nodes (or branches) may need to be added or removed. The simplest solution would be to simply regenerate the graph if there is an impact - but expanded nodes should be restored.

dvstans commented 4 years ago

This has been hacked for now by simply reloading the entire graph on any update (very bad). The problem is that deps would need to be added to updates i DB methods that affect them, but there is no current way for the graph to differentiate between an update that was not modified (deps wise) versus one that has had all deps removed (thanks to the way google protobufs are implemented). To get around this, a "deps_avail" flag will need to be added and set only when deps are returned from the DB. This will allow the graph to analyze the updates for impacts to the currently visible nodes (add/remove nodes & links)

dvstans commented 4 years ago

Fixed - not perfect, but only reloads graph is relevant dependencies have changed on updates.