ORNL / DataFed

A Federated Scientific Data Management System

https://ornl.github.io/DataFed/

Other

18 stars 14 forks source link

Change ACLUpdateRequest to use ACLRule #773

Open dvstans opened 3 years ago

dvstans commented 3 years ago

The ACL update message uses a JSON string payload for rules - this should be changed to use the existing ACLRule structure.

JoshuaSBrown commented 1 year ago

Clarification

Where is the existing ACLRule structure defined if it is not JSON?

dvstans commented 1 year ago

There is an ACLRule message type defined in the SDMS.proto file (used to return ACLs for display), but the ACLUpdateRequest message just takes JSON. It should specify an array of ACLRule sub-documents. None of this matters if we refactor away from protobuf though.