search

ORNL / DataFed

A Federated Scientific Data Management System
https://ornl.github.io/DataFed/
Other
19 stars 14 forks source link

PkgConfig is (may be) used by the build system but not listed as dependency #863

Open dvstans opened 1 year ago

dvstans commented 1 year ago

I'm not sure why PkgConfig is needed in the cmake build file. Need to determine if it really is needed and either document it, or remove it if it isn't needed.

JoshuaSBrown commented 1 year ago

It looks like I added that, it was necessary when ZeroMQ did not support fully the CMake package configuration files. Now they do, I think it can be removed and replaced, i.e. these lines can be changed I believe:

  ## load in pkg-config support
  find_package(PkgConfig)
  ## use pkg-config to get hints for 0mq locations
  pkg_check_modules(PC_ZeroMQ QUIET zmq)

  ## use the hint from above to find where 'zmq.h' is located
  find_path(ZeroMQ_INCLUDE_DIR
          NAMES zmq.h
          PATHS ${PC_ZeroMQ_INCLUDE_DIRS}
          )

  ## use the hint from about to find the location of libzmq
  find_library(ZeroMQ_LIBRARY
          NAMES zmq
          PATHS ${PC_ZeroMQ_LIBRARY_DIRS}
          )

  include_directories( ${ZeroMQ_INCLUDE_DIR} )
  link_directories( ${PC_ZeroMQ_LIBRARY_DIRS} )

To 

find_package(ZeroMQ REQUIRED)