search

ORNL / DataFed

A Federated Scientific Data Management System
https://ornl.github.io/DataFed/
Other
19 stars 14 forks source link

Add latest tag #998

Closed JoshuaSBrown closed 2 months ago

JoshuaSBrown commented 2 months ago

Description

In installing a DataFed repo at Drexel, it was discovered that there were problems with the image containers. It turns out that the release CI pipelines were missing the :latest tag when pushing to the registry. This was causing the end-to-end tests to give false positives in the pipelines. It is fixed in the devel branch because the CI pipeline files were refactored. Merging this should cause the CI pipelines to reproduce the errors that Drexel and LeHigh were observing.

Summary by Sourcery

Add the :latest tag to Docker image pushes in CI pipeline scripts to ensure the latest version is tagged correctly, and update the changelog to reflect this change.

CI:

Documentation:

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request addresses an issue with Docker image tagging in the CI pipeline. The main change is the addition of the ':latest' tag when pushing Docker images to the registry. This fix is implemented across multiple CI configuration files to ensure consistent image versioning and accurate end-to-end test results.

File-Level Changes

Change Details Files
Add ':latest' tag when pushing Docker images in CI pipeline
  • Update docker push command to include ':latest' tag
  • Ensure consistent tagging across different build scenarios (base image, GCS image, forced builds)
 .gitlab/build/build_gcs_base_image.yml
.gitlab/build/build_gcs_image.yml
.gitlab/build/force_build_gcs_base_image.yml
.gitlab/build/force_build_gcs_image.yml
.gitlab/common.yml
Update CHANGELOG.md with new fix information
  • Add entry for fixing missing ':latest' tag on push in container
 CHANGELOG.md
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.