search

ORNL / ReSolve

Library of GPU-resident linear solvers
Other
54 stars 2 forks source link

Ascent build system based on LLVM clang #103

Closed nkoukpaizan closed 9 months ago

nkoukpaizan commented 10 months ago

This PR adds the ascent-llvm CMake preset to build with LLVM clang on Ascent.

Closes #13

nkoukpaizan commented 10 months ago

There was a failing test on Ascent earlier. It passed when I re-ran, but that raises some flags for me.

pelesh commented 10 months ago

There was a failing test on Ascent earlier. It passed when I re-ran, but that raises some flags for me.

This example is nondeterministic due to algorithm used in cusolverRf library. We need to figure out how to set better pass/fail criteria for that test. Thanks for flagging it.

pelesh commented 9 months ago

There was a failing test on Ascent earlier. It passed when I re-ran, but that raises some flags for me.

This issue was fixed by @kswirydo in #109.

@nkoukpaizan, thanks for drawing attention to this.

cameronrutherford commented 9 months ago

@ryandanehy or @nkoukpaizan or myself should be able to add a separate Ascent testing pipeline with this new compiler configuration. Might require some small re-arch, but should be doable. Can be addressed in another PR if not immediately doable.

pelesh commented 9 months ago

@ryandanehy or @nkoukpaizan or myself should be able to add a separate Ascent testing pipeline with this new compiler configuration. Might require some small re-arch, but should be doable. Can be addressed in another PR if not immediately doable.

No need for that b/c it is getting out of service soon.

pelesh commented 9 months ago

@nkoukpaizan, could you rebase to develop just to make sure all tests indeed pass. We can merge after that.