search

ORNL / ReSolve

Library of GPU-resident linear solvers
Other
58 stars 2 forks source link

SDK compliance of adding api version #111

Closed ryandanehy closed 11 months ago

ryandanehy commented 11 months ago

Add version.cpp function that grabs the version of resolve in order to satisfy SDK compliance. In reference to #2

ryandanehy commented 11 months ago

I included a test within make test that runs the function so the pipelines should be doing tests of it.

ryandanehy commented 11 months ago

Since we are preparing alpha release, how will function int ResolveVersionGetVersion(int *, int *, int *); handle something like 1.0.0-alpha1? Perhaps we could add version label to the versioning?

This function was designed to make our lives potentially easier in future releases. I imagined a scenario in which we would want to change the cmake based on whether the version was less than or greater than a particularly major or minor release. In this situation the alpha part doesn't really matter in my opinion because any major change that would utlize this function would result in a change in major, minor or patch number right? And we always have the ReSolveVersionGetVersionstr function to get the whole version.

ryandanehy commented 11 months ago

How are we feeling about this pr?

pelesh commented 11 months ago

How are we feeling about this pr?

I just added a couple of touches and managed to break the build :). I think if tests pass, we can merge this.