search

ORNL / ReSolve

Library of GPU-resident linear solvers
Other
58 stars 2 forks source link

Let classical Gram-Schmidt fail expectedly #142

Closed pelesh closed 9 months ago

pelesh commented 9 months ago

Classical Gram-Schmidt orthogonalization is numerical unstable. Rather than relaxing unit test passing criteria for this method, let us flag it as an expected failure. This will also signal users not to use this method, which is provided in ReSolve for completeness purposes.

This is also a very good demo of status.expectFailure() feature in our unit testing framework 😄 .

pelesh commented 9 months ago

CC @cameronrutherford @maksud

kswirydo commented 9 months ago

LGTM. Maybe if we had CDash configured we could get a better sense of how often this passes/fails

It fails on CPU but passes on nvidia GPU. Let me try hip too. Edit: HIP also passes. So only fails o GPU. And results are reproducible.