search

ORNL / ReSolve

Library of GPU-resident linear solvers
Other
51 stars 1 forks source link

Consider target-link-libraries as you go #145

Open pelesh opened 4 months ago

pelesh commented 4 months ago

Consider adding target link library instructions in CMake files in Re::Solve subdirectories. Currently, target link library instructions are all in CMake file in the resolve directory. Moving these commands to subdirectories would make resolve dir CMake less cluttered and more intuitive.

This was suggested by @cameronrutherford in #140 (see below). 

install(FILES ${Options_HEADER_INSTALL} DESTINATION include/resolve/utilities/options)

target_link_libraries(...)

Per my previous comments, we would just be moving where the target_link_libraries call actually happens. Again, purely a cosmetic suggestion

_Originally posted by @cameronrutherford in https://github.com/ORNL/ReSolve/pull/140#discussion_r1501104271_

pelesh commented 4 months ago

CC @cameronrutherford @kswirydo

pelesh commented 1 month ago

CC @superwhiskers