ORNL / ReSolve

Library of GPU-resident linear solvers
Other
51 stars 1 forks source link

Ensure commutativity of GMRES solver configuration settings #148

Closed pelesh closed 3 months ago

pelesh commented 3 months ago

The objective is to set GMRES configuration options in any order and get the same result. Currently, setting matrix must happen after all other configuration options are set. This PR includes:

All of these settings can take place in any desired order, before or after solver's setup method is called.

pelesh commented 3 months ago

@kswirydo, would you think that Gram-Scmidt setup call should be made from inside of a GMRES class rather than outside of it? I would think a GMRES class should set up the Gram-Schmidt to its liking. It is hard to think of a scenario where the GS method would allocate its data to sizes other than what the calling GMRES requires.