Open superwhiskers opened 1 month ago
some additional comments:
@cameronrutherford and @ryandanehy, please chime in.
CC: @kswirydo
Closed #82. I think we could close #54 without doing C++ formatting, and then have the clang-format and clang-tidy hooks added in another PR/Issue.
+1 to the clang-tidy suggestion. Might be worth discussion in another issue and closing out one thing at a time.
related to #54 / #82, albeit it deserves a dedicated pull request to unbundle it from the addition of
pre-commit
rationale
currently,
CONTRIBUTING.md
is insufficiently precise in some ways and the repository's existing.clang-format
file is not used and does not match the conventions withinCONTRIBUTING.md
exactly. clarifying the style guidelines and setting up.clang-format
would help maintain a consistent style across the codebase and potentially make it more welcoming to newcomersconsiderations
CONTRIBUTING.md
?pre-commit
instead, as described in #54?initial suggestions
.clang-format
file in.github/workflows
^1 since it isn't used and remove the dead code within the rootCMakeLists.txt
^2 that references it.clang-format
at the repository's root which takes into account existing style conventions + the stuff withinCONTRIBUTING.md
, with a priority toward the latter, updatingCONTRIBUTING.md
accordingly