add a LUSOL functionality test

ORNL / ReSolve

Library of GPU-resident linear solvers

Other

58 stars 2 forks source link

add a LUSOL functionality test #164

Closed superwhiskers closed 2 months ago

superwhiskers commented 5 months ago

this pull request adds a functionality test for LUSOL. there is one thing that needs to be worked out before this can actually be merged:

how do we finish implementing symmetric matrix expansion functionality? this is necessary for the integration test to work since LUSOL cannot operate on symmetric matrices stored only as a half (#155)
- currently, i've added a single method to the matrix::Coo class which expands the matrix. this is not permanent and it should be fully expanded upon prior to a merge with equivalent functionality for other matrix types

superwhiskers commented 5 months ago

oh. this also adds comments referencing stuff about extracting L/U factors. i'll remove that so this can be focused only on testing

pelesh commented 5 months ago

@superwhiskers, I suggest you add fix for #162 to this PR.

superwhiskers commented 5 months ago

rebased on latest develop

cameronrutherford commented 5 months ago

https://github.com/ORNL/ReSolve/blob/lusol-integration-tests/examples/CMakeLists.txt#L140 - might be good to have Lusol be used in the consumer test for testing resolve~cuda~rocm~klu+lusol

pelesh commented 5 months ago

https://github.com/ORNL/ReSolve/blob/lusol-integration-tests/examples/CMakeLists.txt#L140 - might be good to have Lusol be used in the consumer test for testing resolve~cuda~rocm~klu+lusol

I agree. To get there, we need to get LUSOL to work within a refactorization solver strategy, which is outside the scope of this PR.

pelesh commented 2 months ago

Closing in favor of #189.