rename `owns_gpu_data_` / `owns_gpu_values_` / etc. to `owns_gpu_sparsity_pattern_` / `owns_gpu_nonzeroes_` / etc.

ORNL / ReSolve

Library of GPU-resident linear solvers

Other

51 stars 1 forks source link

rename `owns_gpu_data_` / `owns_gpu_values_` / etc. to `owns_gpu_sparsity_pattern_` / `owns_gpu_nonzeroes_` / etc. #167

Open superwhiskers opened 2 weeks ago

superwhiskers commented 2 weeks ago

as was brought up in #164 by @pelesh, the current names of these fields is unclear. they should be renamed to something like owns_gpu_sparsity_pattern_ and owns_gpu_nonzeroes_ (with equivalents for the cpu)

rename owns_gpu_data_, owns_gpu_values_, owns_cpu_data_, owns_cpu_values_ to the proposed names
rename the methods for setting them on Sparse
add methods for getting them?

pelesh commented 2 weeks ago

I think an easy solution would be to rename owns_*_data_ to owns_*_indices_. Since these are matrix class member variables, I think it would be clear these refer to matrix values and indices. @kswirydo, please chime in.