ORNL / TASMANIAN

The Toolkit for Adaptive Stochastic Modeling and Non-Intrusive ApproximatioN
https://ornl.github.io/TASMANIAN/
Other
65 stars 24 forks source link

Add long int support for data #6

Open mkstoyanov opened 6 years ago

mkstoyanov commented 6 years ago

No need to overhaul the index set class, only the values storage class and the associated load/unload commands. Check to see how this would affect the ML capabilities.

mkstoyanov commented 6 years ago

Updated design decision:

mkstoyanov commented 6 years ago
mkstoyanov commented 5 years ago
mkstoyanov commented 4 years ago
mkstoyanov commented 4 years ago

Decision: switch internal indexing to long long

Unsigned nature of size_t limits some algorithms, such as searching and special traversals of tensor points. The signed integers also don't suffer from OpenMP limitations on some platforms.

The unsigned indexing also causes issues, since without warnings enabled, using negative numbers in size_t does not result in compile time error but in using maximum number. Hence, signed integers do not provide reasonable safety. Signed indexing is good.