renan-souza
commented
2 days ago Please create a new branch, from this one, to implement these other changes, so I can merge it into dev. If you want to prioritize in smaller PRs, please do the optional dependencies first then the automatic versioning. Feel free to propose improvements. We won't create a new repo. Thanks
On Thu, Oct 17, 2024, 12:26 PM Gavin Wiggins @.***> wrote:
@.**** commented on this pull request.
On pyproject.toml https://github.com/ORNL/flowcept/pull/151#discussion_r1805079734:
It might be easier to just create a separate flowcept repository with all of these fixes. Call it "flowcept2" for example. Other than the dependency and version number fixes, there are lot of things that need to be fixed with the unit tests and how the GitHub Actions workflows are done. And I haven't even mentioned the documentation fixes. This is basically like going from a version 1.0 to a version 2.0 with breaking changes.
— Reply to this email directly, view it on GitHub https://github.com/ORNL/flowcept/pull/151#discussion_r1805079734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANMOYWBOSHZ7FR2EU2YWL3Z37QKHAVCNFSM6AAAAABQAKOITGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZVG4ZDSNBXGY . You are receiving this because your review was requested.Message ID: @.***>
wigging
This replaces the outdated setup.py packaging and uses the modern pyproject.toml approach. The requirements text files are also removed as that functionality can be obtained from the pyproject configuration. All code linting and formatting is now done with ruff instead of flake8 and black. Tests related to zambeze have been removed since that project is being re-evaluated. Adjustments to the GitHub Actions workflows have also been made to accommodate the changes in this pull request. ~Updates to fix linter and formatter warnings will be done in future pull requests.~ Linter and formatter warnings have been fixed but more informative docstrings are still needed.