search

ORNL / hykkt

HyKKT is an experimental linear solver for Karush-Kuhn-Tucker type of systems.
Other
12 stars 2 forks source link

Refactor CI and Mirror to PNNL #1

Closed ryandanehy closed 1 year ago

ryandanehy commented 1 year ago

This refactors CI to use extends instead of anchors and addresses some concerns such as the inclusion of needs[] to some of the jobs. This also sets up CI pipelines and allows us to migrate the code to github. It will work by having github use actions to mirror the repo over at PNNL gitlab. Everytime a push is done to the github repo it than triggers a pipeline for testing on pnnl hpc reasources. Next steps will be actual migration to github + creation of github secrets such as GIT_USERNAME, GIT_PASSWORD, AND GIT_REPO_URL @CameronRutherford I would love to hear your thoughts on this draft before proceeding.

Fixes #2.

ryandanehy commented 1 year ago

@CameronRutherford when you get a chance can it get a second look?

ryandanehy commented 1 year ago

@CameronRutherford and @pelesh I believe this is good to go. We might have to enable the workflow manually through the settings to get it to run. @pelesh can you check under the actions settings if the workflow called push_mirror is enabled.

cameronrutherford commented 1 year ago

@CameronRutherford and @pelesh I believe this is good to go. We might have to enable the workflow manually through the settings to get it to run. @pelesh can you check under the actions settings if the workflow called push_mirror is enabled.

I suggest just hopping on a quick call to get this working, but LGTM!

ryandanehy commented 1 year ago

Pipelines appear to be up and running now. See gitlab for proof as well https://gitlab.pnnl.gov/exasgd/solvers/hykkt/-/pipelines/20164/builds. I think this is ready or at least very close to being ready to be merged.

cameronrutherford commented 1 year ago

I didn't notice this when I submitted the review, but I don't see any PNNL pipeline status being posted to the GitHub PR, so perhaps something still isn't working correctly.