search

ORNL / intersect-architecture

https://intersect-architecture.readthedocs.io
Creative Commons Attribution 4.0 International
2 stars 0 forks source link

Added howto contribute description to Teams and Publication #13

Closed engelmannc closed 1 month ago

engelmannc commented 1 month ago

For consistency and to link the GitHub repository, I added a howto contribute description to the Teams and Publication section.

naughtont3 commented 1 month ago

To help ensure we know when ready for someone to get a review, I've added a new label ready-for-review. I'd suggest adding that label (and assigning a person) so people know for sure something is ready to be reviewed.

I also added a ready-to-merge label that people can tag PRs with to ensure things are good (to avoid any doubt from CI/checkers).

naughtont3 commented 1 month ago

Also, see these suggestions/guidelines for adding the "contributing" info for the repo.

engelmannc commented 1 month ago

[like] Engelmann, Christian reacted to your message:

From: Thomas Naughton @.> Sent: Thursday, September 26, 2024 8:21:30 PM To: ORNL/intersect-architecture @.> Cc: Engelmann, Christian @.>; Author @.> Subject: [EXTERNAL] Re: [ORNL/intersect-architecture] Added howto contribute description to Teams and Publication (PR #13)

@naughtont3 commented on this pull request.

These changes are fine. However, I wonder if we should call this part of the document About instead of Team & Publications. It is more a page to get more info about the artifacts/project/pubs/team (sort of a catch all).

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v2/url?u=https-3A__github.com_ORNL_intersect-2Darchitecture_pull_13-23pullrequestreview-2D2332275310&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=WI1Stn7K5KKjL-gDZ-QyD7gi5ROhDuizF0YaGzT5YjheiGZX2fdsLaW8SkvAa46y&s=G9ryqkMupKDZd2dcc-sxxN6a22OlnIU0K4iUtAC2Zg0&e=, or unsubscribehttps://urldefense.us/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AEO7NKXTCJ4TDY7QEYM5ID3ZYRUEVAVCNFSM6AAAAABO3GBBJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZSGI3TKMZRGA&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=WI1Stn7K5KKjL-gDZ-QyD7gi5ROhDuizF0YaGzT5YjheiGZX2fdsLaW8SkvAa46y&s=pr9UiAnjd6kWXpppLOjeTOeq6lmMwMuYs0kj1ojUk7M&e=. You are receiving this because you authored the thread.Message ID: @.***>

engelmannc commented 1 month ago

Interesting that liking the e-mail in Outlook does get added as a comment. Nice integration.

"About" may be the right name for this section, but it also sounds a bit generic. IDK

naughtont3 commented 1 month ago

"About" may be the right name for this section, but it also sounds a bit generic. IDK

Agree, but this page is sort of a catch all for info and thinking i'd just have to click to know what an "About" page contains. Whereas would not expect to get contrib info on the Team/Pubs page.

engelmannc commented 1 month ago

[like] Engelmann, Christian reacted to your message:

From: Thomas Naughton @.> Sent: Thursday, September 26, 2024 8:39:34 PM To: ORNL/intersect-architecture @.> Cc: Engelmann, Christian @.>; Author @.> Subject: [EXTERNAL] Re: [ORNL/intersect-architecture] Added howto contribute description to Teams and Publication (PR #13)

"About" may be the right name for this section, but it also sounds a bit generic. IDK

Agree, but this page is sort of a catch all for info and thinking i'd just have to click to know what an "About" page contains. Whereas would not expect to get contrib info on the Team/Pubs page.

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v2/url?u=https-3A__github.com_ORNL_intersect-2Darchitecture_pull_13-23issuecomment-2D2377893943&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=CQxSVkXiSeVCZRmPfahryPd2rhRmDCqtMS7EanGxN1CMELMc76sv24iJsZ8NAHcZ&s=BHxd9S7hGkQxqqc4YaQRz15SXQPRLEDXMCIYzBS-yOI&e=, or unsubscribehttps://urldefense.us/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AEO7NKWAX72S7HX3KOWWZ5TZYRWINAVCNFSM6AAAAABO3GBBJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXHA4TGOJUGM&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=CQxSVkXiSeVCZRmPfahryPd2rhRmDCqtMS7EanGxN1CMELMc76sv24iJsZ8NAHcZ&s=FE1GvBH4v7fZJNqxsxJ1d8l1iw9-xVeZDP2vEpVzV0I&e=. You are receiving this because you authored the thread.Message ID: @.***>