search

ORNL / intersect-architecture

https://intersect-architecture.readthedocs.io
Creative Commons Attribution 4.0 International
2 stars 0 forks source link

aam: sos opview and image(s) #15

Closed naughtont3 closed 1 month ago

engelmannc commented 1 month ago

Looks already pretty good. A few edits:

naughtont3 commented 1 month ago 
* "analysis cluster"=> "analysis cluster computer" (this needs to be readable by a non-geek)

Ok, will make this lower case to match other spots in the file. But the name of the cluster is "Analysis", like "Frontier". It is not really useful to have that name, and agree more important to be readable.

engelmannc commented 1 month ago

[like] Engelmann, Christian reacted to your message:

From: Thomas Naughton @.> Sent: Friday, September 27, 2024 3:43:07 PM To: ORNL/intersect-architecture @.> Cc: Engelmann, Christian @.>; Review requested @.> Subject: [EXTERNAL] Re: [ORNL/intersect-architecture] aam: sos opview and image(s) (PR #15)

Ok, will make this lower case to match other spots in the file. But the name of the cluster is "Analysis", like "Frontier". It is not really useful to have that name, and agree more important to be readable.

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v2/url?u=https-3A__github.com_ORNL_intersect-2Darchitecture_pull_15-23issuecomment-2D2379575553&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=XPT8leZ5qX0F40CxyLfz_iytyn38u0Q8W-eOurqHwMzTtmt0dMD_ejVPxb3bYApq&s=bDDQWO53YxvD7QFJ3cByZxyfd1n7fAKFPcQMGfS-E7c&e=, or unsubscribehttps://urldefense.us/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AEO7NKR4A5OSCRBK2SNPKRTZYV4IXAVCNFSM6AAAAABO6KNJHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGU3TKNJVGM&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=XPT8leZ5qX0F40CxyLfz_iytyn38u0Q8W-eOurqHwMzTtmt0dMD_ejVPxb3bYApq&s=K5cOksKY5ZsSZJZP_xJU-wYRZbdRtJZ660iEClAni-8&e=. You are receiving this because your review was requested.Message ID: @.***>

engelmannc commented 1 month ago

Can this be merged?

naughtont3 commented 1 month ago

i squashed the commits. This should now be ready to merge.