ORNL / intersect-architecture

https://intersect-architecture.readthedocs.io
Creative Commons Attribution 4.0 International
2 stars 0 forks source link

Updated the AAM overview, design patterns and SoS #30

Closed engelmannc closed 1 month ago

engelmannc commented 1 month ago

These corrections were necessary for consistency and clarity:

Please review the edits of your corresponding sections.

engelmannc commented 1 month ago

Approve if you think these edits are OK. Comment if not. I will merge once there is a consensus.

naughtont3 commented 1 month ago

LGTM

engelmannc commented 1 month ago

[like] Engelmann, Christian reacted to your message:


From: Thomas Naughton @.> Sent: Wednesday, October 9, 2024 9:16:22 PM To: ORNL/intersect-architecture @.> Cc: Engelmann, Christian @.>; Author @.> Subject: [EXTERNAL] Re: [ORNL/intersect-architecture] Updated the AAM overview, design patterns and SoS (PR #30)

LGTM

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v2/url?u=https-3A__github.com_ORNL_intersect-2Darchitecture_pull_30-23issuecomment-2D2403443117&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=3Uqut5-L04w1uUvsXQO4Mq--Ih4orKhtQRl0SkJJduSaN7ebWJLDayxkO-4H_vtf&s=Ti6f388qYew4Z4oWf1TPOVDxpZwTaekQRbkKgl8K1sA&e=, or unsubscribehttps://urldefense.us/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AEO7NKT46C6ZVYTJ6LSEYC3Z2WMKNAVCNFSM6AAAAABPVH264CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGQ2DGMJRG4&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=8a4olSL6oWWAikeAfRHE1IvXPpcc0eCVGKgvswDDTUU&m=3Uqut5-L04w1uUvsXQO4Mq--Ih4orKhtQRl0SkJJduSaN7ebWJLDayxkO-4H_vtf&s=mtd6YD4R2hjZ9L9msrIU_St679day9bOP-jfFMksLSQ&e=. You are receiving this because you authored the thread.Message ID: @.***>

engelmannc commented 1 month ago

I forgot to add, feel free to suggest changes (like Thomas did) that I can easily review and commit.

boehms commented 1 month ago

In the future, can we try to follow Mikes approach to the documenting and have a sentence per line? This way it is easier to see the actual changes.

engelmannc commented 1 month ago

The 80-character line break thing is a classic. I blame Thomas. 😁