search

ORelio / Sound-Manager

Manage and share Windows sound schemes, restoring missing sounds on recent Windows versions
79 stars 5 forks source link

Fixed English translation for the SoundManager uninstall dialog. #5

Closed seediffusion closed 4 months ago

seediffusion commented 4 months ago

Fixed the English translation for the SoundManager uninstall dialog, added compile instructions to the readme.

ORelio commented 4 months ago

Thanks for documenting the build instructions, and fixing that missing translation item! I made additions to the build instructions, feel free to review them and make additional fixes and/or let me know if ready to merge, then I'll merge the pull request.

seediffusion commented 4 months ago

I see you changed %sm% to . I thought %sm% was a nice touch since sm = SoundManager, and it conforms to MS-DOS environment variable syntax.

ORelio commented 4 months ago

I mistook it for an actual ms-dos environment variable and got confused, so I thought other people might get confused too?

seediffusion commented 4 months ago

I committed a few changes to the readme.

ORelio commented 4 months ago

OK with the changes. Is the request ready to merge?

seediffusion commented 4 months ago

Yes.