ORelio / Spotlight-Downloader

Download Windows Spotlight images and apply them to wallpaper or lockscreen.
182 stars 27 forks source link

Spotlight Downloader without restriction xx-YY on locale #23

Closed potitpanda closed 3 years ago

potitpanda commented 3 years ago

Hi Orelio Could you send me a new version of SpotlightDownloader without restrictions in locales ? This is most powerful in order to download new images Thanks PS : You can eliminate this restriction in the others versions.
Many Thanks PotitPanda

ORelio commented 3 years ago

Here is the requested build: 📁 SpotlightDownloader.zip

potitpanda commented 3 years ago

Not Working ....

ORelio commented 3 years ago

As requested, the modified build allows you to use arbitrary locales and still works for locales known to work.

> SpotlightDownloader.exe urls --locale fr-FR
https://img-prod-cms-rt-microsoft-com.akamaized.net/cms/api/am/imageFileData/RE4IeBg?ver=a95c

> SpotlightDownloader.exe urls --locale aaa
--locale expected format is xx-XX, e.g. en-US. Locale 'aaa' might not work.
SpotlightAPI: System.IO.InvalidDataException: SpotlightAPI: Missing 'batchrsp/items' field in JSON API response. Locale 'aaa' may be invalid. - Waiting 10 seconds before retrying...

Of course, if the locale is invalid, you won't get anything. All locales I'm aware of were already allowed.

potitpanda commented 3 years ago

I want to use Locale --xx or Locale --xx-XX Locale xxx may not work but locale --xx works without the restriction. See previous version especially for me on august 2021

Le mer. 12 mai 2021 à 22:33, ORelio @.***> a écrit :

As requested, the modified build allows you to use arbitrary locales and still works for locales known to work.

SpotlightDownloader.exe urls --locale fr-FRhttps://img-prod-cms-rt-microsoft-com.akamaized.net/cms/api/am/imageFileData/RE4IeBg?ver=a95c

SpotlightDownloader.exe urls --locale aaa --locale expected format is xx-XX, e.g. en-US. Locale 'aaa' might not work. SpotlightAPI: System.IO.InvalidDataException: SpotlightAPI: Missing 'batchrsp/items' field in JSON API response. Locale 'aaa' may be invalid. - Waiting 10 seconds before retrying...

Of course, if the locale is invalid, you won't get anything. All locales I'm aware of were already allowed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ORelio/Spotlight-Downloader/issues/23#issuecomment-840078115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQD7U27NEUKTZODFGNMTCQLTNLQZBANCNFSM44YBNPCA .

ORelio commented 3 years ago

I don't understand. Two-letters locales work:

> SpotlightDownloader.exe urls --locale fr
--locale expected format is xx-XX, e.g. en-US. Locale 'fr' might not work.
https://img-prod-cms-rt-microsoft-com.akamaized.net/cms/api/am/imageFileData/RWwzKl?ver=65bc

Please provide output of what you are trying to do.

potitpanda commented 3 years ago

I want to use --locale fr or --locale en In a previous version you have done only for me it works... (but the ancient url didn't work)

Le mer. 12 mai 2021 à 23:26, ORelio @.***> a écrit :

I don't understand. Two-letters locales work:

SpotlightDownloader.exe urls --locale fr --locale expected format is xx-XX, e.g. en-US. Locale 'fr' might not work.https://img-prod-cms-rt-microsoft-com.akamaized.net/cms/api/am/imageFileData/RWwzKl?ver=65bc

Please provide output of what you are trying to do.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ORelio/Spotlight-Downloader/issues/23#issuecomment-840107725, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQD7U22B5VXVYVAYCIMXTSLTNLXAHANCNFSM44YBNPCA .

ORelio commented 3 years ago

As shown in my message above, you can use --locale fr with the modified build. And future versions will also have this change.

potitpanda commented 3 years ago

This is not working, no changes Could you modify and rebuild the spotlightdownloader.exe Thanks P

Le ven. 14 mai 2021 à 14:03, ORelio @.***> a écrit :

As shown in my message above, you can use --locale fr with the modified build. And future versions will also have this change.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ORelio/Spotlight-Downloader/issues/23#issuecomment-841200730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQD7U26UG3ZLX3WQTLXKBRTTNUGQ5ANCNFSM44YBNPCA .

ORelio commented 3 years ago

Please provide the exact command line you are typing and a screenshot or copy of the output.

potitpanda commented 3 years ago

The command is:

SpotlightDownloader download --many --maxres --inconsistent-metadata --locale af --outdir SpotlightArchive --locale expected format is xx-XX, e.g. en-US. Locale 'af' might not work.

SpotlightDownloader download --many --maxres --inconsistent-metadata --locale am --outdir SpotlightArchive --locale expected format is xx-XX, e.g. en-US. Locale 'am' might not work. (...)

SpotlightDownloader download --many --maxres --inconsistent-metadata --locale fr --outdir SpotlightArchive --locale expected format is xx-XX, e.g. en-US. Locale 'fr' might not work.

There is always the restriction.

Le ven. 14 mai 2021 à 14:56, ORelio @.***> a écrit :

Please provide the exact command line you are typing and a screenshot or copy of the output.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ORelio/Spotlight-Downloader/issues/23#issuecomment-841226571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQD7U25IICVP7POF4IHKXSDTNUMZHANCNFSM44YBNPCA .

ORelio commented 3 years ago

This is a warning message, not an error. The program will proceed even if you see the warning.

potitpanda commented 3 years ago

I'm not really sure ... In the previous version "for me", they haven't the message.

ORelio commented 3 years ago

Yes, it did not. But now it does. Just have a look at the commit: https://github.com/ORelio/Spotlight-Downloader/commit/2159a22649cefb27f6c263dc8b6baa4ef01ec99b

potitpanda commented 3 years ago

Sorry that's OK