Edge Functionality

[sync-by-unito[bot]]

The strikethrough text was deprecated, please disregard.

Edges are an abtraction for roads and connections between nodes. Their functionality is governed by the “Edge Functionality Script” C# script.

The Edge class extends the following class; MonoBehaviour.

The script imports the following enum ModesOfTransport - (https://trello.com/c/Re9GyDZR )

The Edge class has the following private attribues:

• Origin - a pointer to a junction node
  • initialised to none
  • has a public setter method that permits one (1) assignement, then throws erros
• Destination - a pointer to a junction node
  • initialised to none
  • has a public setter method that permits one (1) assignement, then throws erros
• VehiclesOnRoad - ordered list of pointers to Traveller objects
  • initialised to an empty list
• VehiclesInPrequeue - a list of pointers to Traveller objects that entered the Edge in the last tick
• Length - float
  • public getter

The Edge class has the following public attributes:

• maximum velocity - float // km/h
  • initialised to FLOAT_MAX
• pemitted mode of transport - ModesOfTransport

The Edge class has the following functionality:

• on simulation start - the object spawns a child that is a rectangangle visually connecting the two junction nodes.
• on simulation start - the length of the road edge is calculated as | destination location - origin location | and stored in the length attribute
• on update - the script first orderes the VehicesInPrequeue according to their PositionOnEdge attribute (in descending order, the highest first,) then the script iterates through all vehicles in VehiclesOnRoad and calles their Move() function
• subscribe(traveller) - a public method that adds the traveller to the end of VehiclesOnRoad list.
• unsubscribe(traveller) - a public method that removes the traveller from the VehiclesOnRoad list.

Specified by: Zdenek Plesek

Implemented by: Scott DeVerinne, Oscar Rilot & Tomas Premoli

Validated by:

┆Issue is synchronized with this Trello card by Unito ┆Attachments: Edge.cs:

[sync-by-unito[bot]]

➤ Zdenek Plesek commented:

The following is a list of issues as observed on 08/12/2023 \@ 00:02 on the buildings-edges-travellers-merge branch

Validation Errors in [EdgeFunctionality.cs]

• lines 64 to 85

  • CalculateDeltaD is an Traveller function, probably included accidentally
  • line 73 - velocity clamping
    • performed on DeltaD rather than real velocity
    • would need to be performed on the currentVelocity variable as it currently clamps the distance travelled within a span of time

• lines 88 to 92 - ???

• line 104

  • to ensure meaninguful behaviour for agents navigate the graph an arbitrary number greater than 0 should be returned

• line 110

  • multiplication by 0 is a valid operation

• line 160

  • it is possible to obtain the origin of the junction nodes
  • the object should be scaled and rotated accordingly

scottdeverinne1 & oscarrilot