search

OSALTDev / nya-chan-bot

Nya Chan Discord Bot
Other
3 stars 3 forks source link

additional sound cog #6

Open LucaVazz opened 7 years ago

LucaVazz commented 7 years ago

I was thinking about copying and reusing the skeleton of the music cog for something else sound related. There are already plenty Discrod Bots out there which can grab audio from Youtube or other sources and play them in Voice Channels, so I don't think there is any need to reinvent the wheel here.

One idea I thought up would be to select a random sample from i.e. here and play it.

What do you think? Other ideas? Total disagreement?

Yamitatsu commented 7 years ago

All the stuff out there is for Discord.py 0.16.8, Nya uses Discord.py 1.0.0a which changes a bunch of things for voice channels. I still want to do a proper music fetching / storing / replaying / playlist management thingy Plus there is a lot of problems with songs cutting in the middle If that makes sens ^_^

LucaVazz commented 7 years ago

I understand your point about playlist management, that would indeed be nice.
But what exactly do you mean with "problems with songs cutting in the middle"?

And I just searched around a bit, the Bots I thought about (Dyno, Tatsumaki) are not open source. So that would maybe warrant to implement it here "again".

Yamitatsu commented 7 years ago

Most of the bots I tried, have some problems with certain youtube video, dunno if it is a ffmpeg encoding issue, but those difficult songs have a tendancy to cut in the middle and switch to the next song. Also I like your idea about grabbing from freesoung.org

LucaVazz commented 7 years ago

As far as I remember I haven't encountered that problem yet.

Could you maybe create an Issue specific for the music cog and include some links to exemplary Youtube videos which cause it there?

LucaVazz commented 7 years ago

(Updated description slightly to better reflect the intention for this issue)

Yamitatsu commented 7 years ago

I could but it would need to be an issue reported on Red bot or stuff like that, and I don't remember the link right now... Plus, the issue might as well be server side too. I'll see that when I start working on it.