OSAS / strapping-mediawiki

base skin for MediaWiki, based on Bootstrap — layer your own style (fonts, graphics, color) on top
Other
146 stars 35 forks source link

CSS issue - Elements are not centered #27

Closed clintongreen closed 11 years ago

clintongreen commented 11 years ago

I have tried with 2 fresh installs but I still find that everything is off-centered. I managed to fix it by adding .row,[class*="span"]{ margin-left: 0;} to theme.css. This then affected the offset class so I needed to add them in theme.css too. Is this a bug or am I missing something? I've attached a screenshot that shows the elements off-center. I added a border on everything for this screen shot. Thanks for skin :)

image

garrett commented 11 years ago

I believe this resulted from a previous update to the skin where a <div> was replaced with a <ul> and <li>, and those brought along their own margin.

(The outlines on the left are intentional, as that's how CSS grids usually work. It's basically the header that's shifted out of place.)

I have a fix and will be applying it soon.

clintongreen commented 11 years ago

Thanks Garrett. I'll check for the next release. Cheers

garrett commented 11 years ago

Oh, I was actually thinking of something else for the explanation.

I'm about to submit a really simple CSS change that should fix this. Please let me know if it works for you.