search

OSC / bc_js_filepicker

A file picker for Batch Connect applications
MIT License
2 stars 6 forks source link

Can't select favorite as the directory directly #204

Open Micket opened 1 year ago

Micket commented 1 year ago

Using data-target-file-type: dirs and selecting a Favorite and pressing "Select" doesn't pick up the directory. I have to select something on the right hand side, but the . directory isn't selectable, there is no way to directly use a favorite. Instead, I have to go 1 dir up, which in my case means hundreds of project directories, and requires that I scroll to my project area manually. I also have no way of not selecting a subdirectory when such a dir exists, again forcing me to go up 1 dir.

I'm also not sure my users would necessarily recognize . and .. even if they were selectable.

johrstrom commented 1 year ago

Hi, thanks for the ticket - but I have to say it won't be worked. This is being replaced in 3.1 with a native path_selector widget.

https://github.com/OSC/ondemand/issues/1571

That said - it (the newer implementation) doesn't show favorites at all at the moment (and likely won't in 3.1 because it's coming soon) but I made a ticket for the same.

johrstrom commented 1 year ago

Well I should say, it won't be worked by OSC. If you submit a patch for this issue (or the other), I'd be happy to review and merge it.

Micket commented 1 year ago

I was new to the file picker to begin with, wasn't aware of the native widgets WIP. I'll be happy to jump over to 3.1 as soon as possible!

johrstrom commented 1 year ago

Well there's an open pull request to maybe fix this so I can reopen.

johrstrom commented 1 year ago

Also - I can't seem to replicate on OOD 3.0.1 and this library at 3.0.1 as well.