search

OSC / bc_osc_codeserver

BETA - Batch Connect - OSC Code Server
https://osc.github.io/Open-OnDemand/
GNU General Public License v3.0
18 stars 21 forks source link

Add code-server 4.5.1 #27

Closed ZQyou closed 2 years ago

ZQyou commented 2 years ago

I have added 4.5.1 to form.yml and made changes in script.sh.erb due to the option --extra-extensions-dir is removed in version 4.

code-server can start normally but I cannot log in (with the message "401 Unauthorized" on login page). Here is my output.log

Script starting...
Thu Jul 28 14:49:52 EDT 2022: Waiting for Code Server to open port 7659...
Thu Jul 28 14:49:53 EDT 2022: Running on compute node :7659
Thu Jul 28 14:49:53 EDT 2022: Started code-server

[2022-07-28T18:49:55.706Z] info  code-server 4.5.1 97d170331b51ee75c8e4bbdab23c755e3eeaaa8c
[2022-07-28T18:49:55.707Z] info  Using user-data-dir ~/.local/share/code-server
[2022-07-28T18:49:55.725Z] info  Using config file ~/.config/code-server/config.yaml
[2022-07-28T18:49:55.725Z] info  HTTP server listening on http://0.0.0.0:7659/
[2022-07-28T18:49:55.725Z] info    - Authentication is enabled
[2022-07-28T18:49:55.725Z] info      - Using password from $PASSWORD
[2022-07-28T18:49:55.725Z] info    - Not serving HTTPS
Thu Jul 28 14:49:56 EDT 2022: Discovered code-server listening on port 7659!
Generating connection YAML file...
[14:50:14] Extension host agent started.
[2022-07-28T18:50:14.967Z] debug redirecting from /? to ./login?to=
[14:50:15] ComputeTargetPlatform: linux-x64
ZQyou commented 2 years ago

I have added 3.10.2, 3.11.1, 3.12.0, 4.0.2 for testing. The login failure (wrong redirecting?) happens starting from 3.11.

johrstrom commented 2 years ago

We've heard a lot of similar reports from discourse.

Docs say:

HTTP servers should use relative URLs to avoid the need to be coupled to the absolute path at which they are served. This means you must [use trailing slashes on all paths with subpaths](https://blog.cdivilly.com/2019/02/28/uri-trailing-slashes).

Which may be our issue.

ZQyou commented 2 years ago

I have removed 3.10.2, 3.11.1, 3.12.0 and 4.0.2 since they all have the same issues.

ZQyou commented 2 years ago

Any update on resolving the issue?

johrstrom commented 2 years ago

Are the broken module still available? I believe we'll need them if not, or maybe we'll have to set them up as personal modules?

ZQyou commented 2 years ago

4.5.1 is still available on Pitzer

module load project/ondemand
module load app_code_server/4.5.1
Oglopf commented 2 years ago

I opened a separate request for this change, didn't see this until after I'd opened it. I'm going to close this out as the other PR is in a working state.