OSC / bc_osc_codeserver

BETA - Batch Connect - OSC Code Server
https://osc.github.io/Open-OnDemand/
GNU General Public License v3.0
18 stars 21 forks source link

Add nonce for to js for login to work with CSP #32

Closed Oglopf closed 1 year ago

johrstrom commented 1 year ago

I know we've had issues with opening on the working_dir. I've found that the setting is in this file. If we want to continue to open on that initial directory we may be able to edit this file before we launch.

jq '.' ~/.local/share/code-server/coder.json
johrstrom commented 1 year ago

This works for me, IDK if you want to play around with the contents of ~/.local/share/code-server/coder.json in this PR or just defer it.

Oglopf commented 1 year ago

I'm going to try and fix that too in the script, will update soon with that.

johrstrom commented 1 year ago

I'm finding a few things here

Here's the diff I've been testing with.

diff.txt

Oglopf commented 1 year ago

Wait, do you want that extra-extensions or not? I'm confused now as this was removed before, then put in, and now we want to remove it?

johrstrom commented 1 year ago

Wait, do you want that extra-extensions or not? I'm confused now as this was removed before, then put in, and now we want to remove it?

Yea I think so. I don't see it as a valid option for any version. Extensions are picked up in #{--user-data-dir}/extentions so I don't really know what this does, if anything.

Again - I cannot find it as a valid option for any version and extensions work fine without it.