search

OSC / bc_osc_qgis

Batch Connect - OSC QGIS
1 stars 2 forks source link

app not using full screen #14

Open johrstrom opened 2 years ago

johrstrom commented 2 years ago

The app does not take up the entire screen of the view port. This is likely a bad experience for users.

image

hansen-m commented 9 months ago

Seeing the same issue. @johrstrom Did you find a fix?

johrstrom commented 9 months ago

Logging into production this morning I don't see the same. I may have fixed it in #20.

hansen-m commented 9 months ago

Interesting. I have that fix and am still seeing it. Issue has persisted after updating ubunutu/qgis in the Singularity image. I can expand the lower right corner but there's still a strange padding around the left and top sides.

Screenshot 2024-02-20 at 9 47 21 AM
johrstrom commented 9 months ago

Well I can say it's definitely an underlying XFCE/DBUS issue, because you don't even see the desktop. Let me remove that line and see if that replicates the issue.

johrstrom commented 9 months ago

ODD - I just tested on el8 and it works without that export. IIRC I had to patch in #20 because of some OS updates during a system downtime. But we've since upgraded from el7 to el8.

In any case, maybe it's the & that's throwing this off - https://github.com/OSC/bc_osc_qgis/blob/edcc20ca28a743366dd30b908f3c095f0b751918/template/script.sh.erb#L37

Like it shouldn't be parallel and/or you need to sleep to let it finish?

hansen-m commented 9 months ago

Without the & it doesn't seem to launch successfully at all. Might be something else going on though with the --daemon flag.

Setting VNC password...
Starting VNC server...

Desktop 'TurboVNC: p-ic-4001:6 (mah60)' started on display p-ic-4001:6

Log file is vnc.log
Successfully started VNC server on p-ic-4001:5906...
Script starting...
Starting websocket server...
The system default contains no modules
  (env var: LMOD_SYSTEM_DEFAULT_MODULES is empty)
  No changes in loaded modules

+ xfwm4 --compositor=off --daemon --sm-client-disable
xfwm4: Unknown option --daemon.
Type "xfwm4 --help" for usage.
+ xsetroot -solid '#D3D3D3'
WebSocket server settings:
  - Listen on :10417
+ xfsettingsd --sm-client-disable
  - Flash security policy server
  - No SSL/TLS support (no cert file)
  - Backgrounding (daemon)
Scanning VNC log file for user authentications...
Generating connection YAML file...

(xfsettingsd:330972): GLib-CRITICAL **: 10:05:27.631: g_str_has_prefix: assertion 'prefix != NULL' failed

(xfsettingsd:330972): GLib-GObject-CRITICAL **: 10:05:27.633: g_value_get_string: assertion 'G_VALUE_HOLDS_STRING (value)' failed

(xfsettingsd:330972): GLib-GObject-CRITICAL **: 10:05:27.633: g_value_get_string: assertion 'G_VALUE_HOLDS_STRING (value)' failed

(xfsettingsd:330972): GLib-GObject-CRITICAL **: 10:05:27.635: g_value_get_string: assertion 'G_VALUE_HOLDS_STRING (value)' failed
xfsettingsd: No window manager registered on screen 0.

(xfsettingsd:330972): xfsettingsd-WARNING **: 10:05:32.758: Failed to get the _NET_NUMBER_OF_DESKTOPS property.
hansen-m commented 9 months ago

Ok, so progress.

Removing the --daemon flag, keeping the & and adding a sleep 10 before calling singularity seems to have fixed it. I see the window menus now and everything is movable and resizable.