Make editor and shell url prefixes set by config in app.js

OSC / cloudcmd

Cloud Commander orthodox web file manager with console and editor.

cloudcmd.io

0 stars 0 forks source link

Make editor and shell url prefixes set by config in app.js #26

Closed ericfranz closed 8 years ago

ericfranz commented 8 years ago

Changes provided ensure that you set the prefixes in app.js i.e.

file_editor: "/pun/dev/osc-editor/edit",
shell: "/pun/sys/shell/ssh/default"

Fixes https://github.com/AweSim-OSC/osc-fileexplorer/issues/81

ericfranz commented 8 years ago

@brianmcmichael please review

brianmcmichael commented 8 years ago

I'd already done this on a branch and it didn't work for me. The config options are always passing in an empty string to the renderer. Have you tested this?

ericfranz commented 8 years ago

Yes I tested and it works :-)

ericfranz commented 8 years ago

Note: you can't use "editor" as CloudCommander seems to reserve that. When I used "editor" for the config name and not "file_editor" it wasn't rendering for me either.