search

OSC / cloudcmd

Cloud Commander orthodox web file manager with console and editor.
cloudcmd.io
0 stars 0 forks source link

downloading to system route #36

Closed brianmcmichael closed 8 years ago

brianmcmichael commented 8 years ago

First commit is a quick fix for the download issue described in https://github.com/OSC/ood-fileexplorer/issues/126

Content-disposition is not set yet so things like *.txt files are being rendered rather than downloaded. Response headers will need to be set on the system.

This will also need to be expanded to include an optional envvar, and if the system version is not available, fall back to the application's download handler.

ericfranz commented 8 years ago

So the default is: prefixUr + FS and the thing we would be setting in the env var is /pun/download but theoretically in both cases we would append path+'?download'?

brianmcmichael commented 8 years ago

Yes, the only thing that would change is the api route.

brianmcmichael commented 8 years ago

@ericfranz please review

brianmcmichael commented 8 years ago

This is javascript.

js

ericfranz commented 8 years ago

Very good. How is ood_download set in lib/client/ood.js?

ericfranz commented 8 years ago

After that one fix, update README for installation directions. Then its good.

brianmcmichael commented 8 years ago

updated readme at https://github.com/OSC/ood-fileexplorer