search

OSC / cloudcmd

Cloud Commander orthodox web file manager with console and editor.
cloudcmd.io
0 stars 0 forks source link

Lock in working dependencies. #39

Open brianmcmichael opened 7 years ago

brianmcmichael commented 7 years ago

The existing OSC version of cloudcmd allows for minor version updates in the package.json

This has worked well enough, as we've been able to take advantage of minor version updates to dependencies to this point. However, the original developer has begun using ES6 in the latest update to "faust": "1.0.6" from 1.0.4, which appears to be incompatible with our version of node/passenger.

I'm going to need to lock in faust at 1.0.4 and will probably need to go ahead and lock in the remaining dependencies at their currently supported version.

ericfranz commented 7 years ago

https://www.npmjs.com/package/faust

What is faust used for? Can we just remove it as a dependency?

brianmcmichael commented 7 years ago

Maybe, but it's only one of a few dozen dependencies that can potentially give us the same problem.

The npm-shrinkwrap is really of no use in this case, because updating to the latest OSC/cloudcmd tag will use the package.json in there, which wants to get the latest versions. Maybe adding a package.json to the OSC/cloudcmd repo itself would solve this.

coderaiser commented 7 years ago

@brianmcmichael issue with faust fixed in v1.0.7, it was a bug. I use prefix legacy for libraries written in es6 and up major version like it made in currify. Please try to use last versions of libraries, i try to fix bugs and to make code better :).

What is faust used for? Can we just remove it as a dependency?

Yes it could be removed, and it is removed in the last version of Cloud Commander.

Cloud Commander and all it's dependencies uses es5 only. When something will be changed major version will be bumped up.

Please create an issue when you see that something is broken.

What version of node.js are you using? Do you know that node.js v0.10 is deprecated and v0.12 will be deprecated at the end of next month?

brianmcmichael commented 7 years ago

Hi @coderaiser

This isn't your fault. We're running a fork based on cloudcmd v5.3.1 and at this point we've heavily customized and diverged from master.

I'm going to try to make issues and push improvements/fixes to upstream where applicable, but some of our issues are a result of modifications we've made from master branch.

As far as node goes, we're running Software Collections nodejs010 on RHEL6. We're locked into that right now because there is no Software Collections package for v0.12 available for RHEL6, and this is running on a supercomputer cluster that can't be updated to RHEL7 at the time. Which means we're stuck with v0.10 for the time being.

I've added a npm-shrinkwrap to our fork of cloudcmd that addresses our issue.

brianmcmichael commented 7 years ago

In case you're curious, this is what it looks like now. It's using cloudcmd as a dependency.

cloudcmd

coderaiser commented 7 years ago

Looks interesting :). I'm glad that Cloud Commander could be useful as a middleware. About node.js, you can use nvm to install any version with zero hustle.