OSC / nginx_stage

[MOVED] Stages & controls the per-user NGINX environment
https://github.com/OSC/ondemand/tree/master/nginx_stage
MIT License
0 stars 1 forks source link

Validate usernames with '@' signs #19

Closed kmanalo closed 7 years ago

kmanalo commented 7 years ago

We have usernames like 'jdoe@location.edu'

nickjer commented 7 years ago

@kmanalo after you hand-edited the regular expression to get it to work at your center, and assuming you get the cluster configuration file sorted, could you confirm that all the apps work fine with these formatted usernames.

For example:

kmanalo commented 7 years ago

I'll let you know how my testing goes today - most of my testing was using a 'shortname' account without any symbols like @

But currently I'm seeing general access errors, with no obvious reports after the initial username and password entry:

We're sorry, but something went wrong.

We've been notified about this issue and we'll take a look at it shortly. However, working with regular usernames I can see the dashboard and apps just fine.

It's probably having an affect downwind but I'm not clear where. When you have a chance, can you take a look at this behavior? I will give you feedback with regular usernames first (where it works), as not all the apps had full 100% functionality.

We are also a site using two-factor authentication.

On Tue, Aug 8, 2017 at 3:42 PM, Jeremy Nicklas notifications@github.com wrote:

@kmanalo https://github.com/kmanalo after you hand-edited the regular expression to get it to work at your center, and assuming you get the cluster configuration file sorted, could you confirm that all the apps work fine with these formatted usernames.

For example:

  • If home directories have the @ symbol in their name, does the File Explorer & File Editor work?
  • Can you launch the Shell app inside one of these directories?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OSC/nginx_stage/issues/19#issuecomment-321060841, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6LGLz1DuifoLn6bYy9jTFvt0gwv4V3ks5sWLowgaJpZM4OxH-G .

kmanalo commented 7 years ago

Update: 1.5.0 appears to work better after I completely removed activejobs and recloned, I can see the attempt to use 'squeue' in the slurm.rb so this is good. I'll continue the discussion for this in the right repo, but will report on issues related to the '@' usernames.

nickjer commented 7 years ago

Have you tried using the ood-apps-installer utility for keeping the individual apps up-to-date. More documentation can be found here:

https://osc.github.io/ood-documentation/master/installation/install-apps.html

As cloning and building each app individually can be a hassle and prone to mistakes.

nickjer commented 7 years ago

Also, the documentation gives an example Slurm cluster config as:

# /etc/ood/config/clusters.d/cluster1.yml
---
v2:
  metadata:
    title: "Cluster 1"
  login:
    host: "cluster1.my_center.edu"
  job:
    adapter: "slurm"
    cluster: "cluster1"
    bin: "/path/to/slurm/bin"

but I forgot to update the documentation and mention there is another parameter called conf that is used to point to the Slurm configuration file for the given cluster. So a better cluster config would look like:

# /etc/ood/config/clusters.d/cluster1.yml
---
v2:
  metadata:
    title: "Cluster 1"
  login:
    host: "cluster1.my_center.edu"
  job:
    adapter: "slurm"
    cluster: "cluster1"
    bin: "/path/to/slurm/bin"
    conf: "/path/to/cluster1/slurm.conf"
kmanalo commented 7 years ago

Thanks, I did set adapter, conf, and bin, as you indicated in the latter

I took out the cluster name part out (as we only have one cluster, and squeue worked without the specifier).

On Wed, Aug 9, 2017 at 11:18 AM, Jeremy Nicklas notifications@github.com wrote:

Also, the documentation gives an example Slurm cluster config as:

/etc/ood/config/clusters.d/cluster1.yml

---v2: metadata: title: "Cluster 1" login: host: "cluster1.my_center.edu" job: adapter: "slurm" cluster: "cluster1" bin: "/path/to/slurm/bin"

but I forgot to update the documentation and mention there is another parameter called conf that is used to point to the Slurm configuration file for the given cluster. So a better cluster config would look like:

/etc/ood/config/clusters.d/cluster1.yml

---v2: metadata: title: "Cluster 1" login: host: "cluster1.my_center.edu" job: adapter: "slurm" cluster: "cluster1" bin: "/path/to/slurm/bin" conf: "/path/to/slurm.conf"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OSC/nginx_stage/issues/19#issuecomment-321287502, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6LGGrgksmzQb_z8XbXmesMlI2VFo1rks5sWc2xgaJpZM4OxH-G .

kmanalo commented 7 years ago

Thanks for that - no I did not know about it.

To give you my POV, we had an instance of OnDemand on a VM running, so I have not read up on some of the initial installation details.

On Wed, Aug 9, 2017 at 11:11 AM, Jeremy Nicklas notifications@github.com wrote:

Have you tried using the ood-apps-installer utility for keeping the individual apps up-to-date. More documentation can be found here:

https://osc.github.io/ood-documentation/master/ installation/install-apps.html

As cloning and building each app individually can be a hassle and prone to mistakes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OSC/nginx_stage/issues/19#issuecomment-321285597, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6LGBgAZ_1BUNIb-brtnHjvU6eNmckUks5sWcw3gaJpZM4OxH-G .