search

OSC / nginx_stage

[MOVED] Stages & controls the per-user NGINX environment
https://github.com/OSC/ondemand/tree/master/nginx_stage
MIT License
0 stars 1 forks source link

Provide an option to set SECRET_KEY_BASE env var in the PUN #32

Open ericfranz opened 6 years ago

ericfranz commented 6 years ago

If we could set SECRET_KEY_BASE in the PUN globally (optionally generate or read a unique value per-user). I'm not sure we want to have this change between PUN invocations though.

One option is that the place to put this is in the /etc/ood/profile, prior to launching the PUN. Then no modification to config file would be required.

  1. Would it be beneficial/desirable that PUN Rails apps share the same SECRET_KEY_BASE or would that be problematic? It could allow for easier interoperability between apps.
  2. Would it be beneficial/desirable to have SECRET_KEY_BASE be a different value from the one committed to the repo. Yes, for security reasons; though some of the problems that SECRET_KEY_BASE is meant to protect against are not problems OOD users likely face due to our architecture.
ericfranz commented 6 years ago

See https://app.asana.com/0/search/514421286954598/511414316847859 and https://github.com/OSC/ood_appkit/issues/31 for related work.