OSC / nginx_stage

[MOVED] Stages & controls the per-user NGINX environment
https://github.com/OSC/ondemand/tree/master/nginx_stage
MIT License
0 stars 1 forks source link

Handle spaces in domain groups correctly #45

Closed CJCShadowsan closed 6 years ago

CJCShadowsan commented 6 years ago

Previous version of this file wouldn't handle spaces in a group - for example if a user had "domain users" as their group, it would fail to start up nginx with an 'incorrect number of arguments' error. Adding the single quotes around this fixes that.

ericfranz commented 6 years ago

Excellent. Thanks!

ericfranz commented 6 years ago

@CJCShadowsan what platform are you installing OnDemand on that you had the need to support groups whose name had a space in them? Yours may be a new case we haven't considered. I'm wondering if we are making other assumptions that we should address.