OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
295 stars 107 forks source link

replace lightbox with plain js in new activejobs #1032

Open johrstrom opened 3 years ago

johrstrom commented 3 years ago

Lightbox was dropped during the merging of activejobs into the dashboard. This ticket is to have a functional replacement with it in plain old javascript.

Something like this should work.

$('#directory-contents tbody').on('click', '.view-file', function(e){
  e.preventDefault();
  let row = table.row(this.dataset.rowIndex).data();
  window.open(row.url, 'ViewFile', "location=yes,resizable=yes,scrollbars=yes,status=yes");
});

Ganglia extended panels use this feature. You can use this config to use Berkeley's public ganglia instance.

    ganglia:
      host: "tiger.cchem.berkeley.edu/ganglia"
      scheme: "http://"
      segments:
        - "graph.php"
      req_query:
        c: "Pitzer"
      opt_query:
        h: "%{h}.ten.osc.edu"
      version: "3

┆Issue is synchronized with this Asana task by Unito

johrstrom commented 1 month ago

Should consider dropping ganglia support altogether, but don't quite know if anyone's actually running it anymore.

In any case, as long as we support ganglia we should actually support it and do this.