search

OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
295 stars 107 forks source link

ActiveJobs: ActiveJobs: Use Info#wallclock_limit for wallclock time #126

Open brianmcmichael opened 7 years ago

brianmcmichael commented 7 years ago

Currently the wallclock times are derived via accessing native attributes, like:

attributes.push Attribute.new "Walltime", (info.native.fetch(:Resource_List, {})[:walltime].presence || "00:00:00")

These can be replaced with something like:

attributes.push Attribute.new "Walltime", info.wallclock_limit || "00:00:00"

After updating to the the latest ood_core release.

┆Issue is synchronized with this Asana task by Unito

ericfranz commented 6 years ago

I think that the adapters all implement this method. Verify that by looking at the ood_core code. If it looks legit, do this feature.

johrstrom commented 4 years ago

This can move forward for torque slurm and pbspro. The only other adapter at present that has extended view (LSF) does not yet have this.

johrstrom commented 7 months ago

Don't know why I thought lsf doesn't have support for this - it did and still does:

https://github.com/OSC/ood_core/blob/4b21ae7bfb9335e248b547296cbac21137fc818f/lib/ood_core/job/adapters/lsf.rb#L205

So in any case, for any implementer of this good first issue -

The line in question that needs updated is here (for torque) in the extended_data_torque method. There will be similar methods for the other schedulers as well. It seems we'd need to support these 4 schedulers: torque, slurm, pbspro and lsf.

https://github.com/OSC/ondemand/blob/43aa06d89689807ed0cae7cf4a85cfb97426bfa6/apps/dashboard/app/models/active_jobs/jobstatusdata.rb#L75