OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
295 stars 107 forks source link

ActiveJobs: Use scrollspy to fix the expanded row at top when it scrolls out of view #133

Open ericfranz opened 8 years ago

ericfranz commented 8 years ago

When I expand a row and then scroll down, I lose the context of the job:

screen shot 2016-06-03 at 1 02 20 pm

screen shot 2016-06-03 at 1 02 24 pm

We can use scrollspy to temporarily apply a "currently-viewing" class to when we scroll past the row so its out of view - this way the information in that row could be displayed:

screen shot 2016-06-03 at 1 02 24 pm copy

You can do this if the "currently-viewing" class applies "position fixed" to the row, but determining the correct style modifications after you do that will take a little bit of time. This screenshot shows a quick example where I pop the row contents out, but it doesn't look ideal:

screen shot 2016-06-03 at 1 06 35 pm

Though even this might be good enough. The styles I used to apply to this would be:


.currently-viewing {
    position: fixed;
    top: 0;
    z-index: 2000;
    background-color: white;
    border: 1px solid #ddd;

    /* round corner and add dropshadow */
    -webkit-box-shadow: 1px 1px 5px 0px rgba(0,0,0,0.75);
    -moz-box-shadow: 1px 1px 5px 0px rgba(0,0,0,0.75);
    box-shadow: 1px 1px 5px 0px rgba(0,0,0,0.75);
    -webkit-border-radius: 5px;
    -moz-border-radius: 5px;
    border-radius: 5px;
}

┆Issue is synchronized with this Asana task by Unito

matt257 commented 7 months ago

reviewed, still a good idea