search

OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
277 stars 103 forks source link

shell app could use some padding/margin on sides #2868

Open johrstrom opened 1 year ago

johrstrom commented 1 year ago

From discourse, it seems that using the entire screen can cut off the first leftmost character.

https://discourse.openondemand.org/t/add-small-offset-to-left-border-of-terminal/2741

martinyis commented 1 year ago

Hey I can work on that issue, where exactly you want to add margin?

johrstrom commented 1 year ago

Took a quick spot check, and it's hard to say (may not be a good first issue).

If I interact with the HTML on the page I can give x-row and x-screen tags margin and padding, but the cursor stays in the same place. That could be because I edited it inline instead of editing the CSS directly, but it seems like those are good places I just don't know off hand how to get the cursor to respect the new position.

That said - there may just be a configuration for this. Though I can't see a clear way to set preferences (we just set the profile and seem to hack localStorage?, there's got to be a better way - hterm docs indicate we should do this: https://chromium.googlesource.com/apps/libapps/+/master/nassh/doc/FAQ.md#how-do-i-set-terminal-preferences)

https://github.com/OSC/ondemand/blob/ee44cd668af04064ca14091ba6d85476f1547c1b/apps/shell/public/javascripts/hterm_all_1.91.mod.js#L10582

johrstrom commented 1 year ago

Let me know if that's enough information or not. A pull request doesn't have to be perfect on the first go, we can work through what may or may not fit.