search

OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
263 stars 99 forks source link

`loginLogo` Needs `url` not a `path #3518

Open Oglopf opened 2 months ago

Oglopf commented 2 months ago

We received a discourse today about setting up the loginLogo and getting errors around its rendering. https://discourse.openondemand.org/t/loginlogo-not-being-found/3429/2

Looking at the docs they shared, it looks like that should only be a path, not a full url like we have documented. It looks to work once you use the url though. It might be we just need to update the docs, but I wanted to check that this isn't a bug first.

johrstrom commented 2 months ago

Is this a ticket here or the documentation? Thinking about this a bit - I'll bet it means the URI path not the filesystem path.

I.e., I'm guessing that

loginLogo: "/public/uos_logo_white_small.png"

would have worked instead of specifying the file system path that included /var/www.

connorourke commented 2 months ago

Having "/public/uos_logo_white_small.png" doesn't seem to work either.

johrstrom commented 2 months ago

It worked for me

image

You can see in the HTML it's the relative URI path.

image