search

OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
280 stars 104 forks source link

Update buttons for bootstrap 5 #3576

Closed ashton22305 closed 3 months ago

ashton22305 commented 4 months ago

Child of #3461

This ticket is to ensure that buttons work and are correctly formatted when upgrading to Bootstrap 5

ashton22305 commented 4 months ago

btn-danger buttons seem to show black text because the contrast calculations changed in Bootstrap 5 to ensure accessibility, causing the contrast between red and white to become too low. image Our danger color doesn't match the default in bootstrap 5 - changing it to the default seems to work image Should we change it? I'm not sure how/if we even should keep the current color.

johrstrom commented 4 months ago

changing it to the default seems to work

You mean changing it back to the default makes the buttons have white text? If that's the case - then yes I'd say let's use the default with white text if that's an option.