search

OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
280 stars 104 forks source link

Update node_proxy.lua - Fix for interactive apps not working #3791

Open giuliolibrando opened 2 weeks ago

giuliolibrando commented 2 weeks ago

Fix for interactive apps not working after Apache 2.4.62, specifically when arguments are passed with ? character

johrstrom commented 2 weeks ago

E2E tests are failing, indicating this change does not do what we'd expect.

johrstrom commented 2 weeks ago

Thanks for the contribution(s), but as I say, this breaks end to end tests, so I can't merge it as is.

johrstrom commented 5 days ago

I'm looking into this now to get it backported to 3.1. What's the status of it on your side @giuliolibrando? I'm working on more end to end tests to verify the behaviors, and may have a patch that works.

Should I just commit to this pull request or should I close this and open another?

giuliolibrando commented 5 days ago

I haven't had a chance to do more tests to understand why the merge pipeline tests are failing, but the apps are working correctly on my local installation. If you've made a better fix, feel free to commit it to this PR. Or let me know if I can do something or do tests

johrstrom commented 4 days ago

It's hard for me to commit to your branch on master. In any case, I applied my fix to #3827.

As to the tests that are passing - you can do this to check: Rstudio's help menus send relative request. i.e., ../../some/help/html/docs. If you tested this against Rstudio it may work for the most part - but I'd guess that the documentation panel is broken.

giuliolibrando commented 3 days ago

@johrstrom if you're referring to this panel seems to work correctly. I tried to navigate some pages and they all loads image