OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
288 stars 106 forks source link

rpm contains test and development dependencies #3821

Closed wijnanjo closed 2 weeks ago

wijnanjo commented 1 month ago

The final rpm used to deploy production should not contain test nor development dependencies. Specifically the bundle gems should not contain webrick, selenium ...

Example, the 'dashboard' Gemfile:

group :test do
  gem "capybara"
  # lock selenium as it doesn't work on ubuntu 22.04
  # https://github.com/SeleniumHQ/selenium/issues/11291
  gem "selenium-webdriver", '4.5.0'
  gem "webrick"
end

However these gems show up here, for example: /opt/ood/ondemand/root/usr/share/gems/3.1/ondemand/3.1.7-1/gems/selenium-webdriver-4.5.0/

I essentially installed on AlmaLinux8 as documented according the documentation:

sudo dnf install https://yum.osc.edu/ondemand/3.1/ondemand-release-web-3.1-1.el8.noarch.rpm
sudo dnf install ondemand
johrstrom commented 1 month ago

Thanks. I agree.