OSC / ondemand

Supercomputing. Seamlessly. Open, Interactive HPC Via the Web
https://openondemand.org/
MIT License
294 stars 106 forks source link

Optimize nav logo sizing #988

Closed ericfranz closed 1 month ago

ericfranz commented 3 years ago

This "defect" was introduced in OOD2.0

In OOD1.8 we had:

screen 2021-03-16 at 10 18 36 PM

Now we have:

screen 2021-03-16 at 10 18 41 PM

So sites using the logo header might be unhappy with the change. The original fix to get this to work in Bootstrap 3 took some clever changes as I recall several custom CSS rules. It could take the same work for this, and there are bigger problems to solve. So maybe worth an issue for an intern to work on later, or we could wait for a complaint. (for example, you could imagine hugging the logo to the left/top of the screen (removing it from the flow) and then inserting extra padding to push the rest of the nav items over - there might be other ideas).

This is affected by env var OOD_DASHBOARD_HEADER_IMG_LOGO. See https://osc.github.io/ood-documentation/latest/customization.html#branding

┆Issue is synchronized with this Asana task by Unito

johrstrom commented 1 month ago

Closing this as it doesn't seem all that important anymore. Plus nobody complained.