Closed nickjer closed 7 years ago
We need to come up with a default view for all HPC apps, or bite the bullet and create separate views for each type of adapter output.
I'm in favor of a uniform display across all installations of this app, for maintainability sake.
I have a proposal. We are already essentially "normalizing" both default and native attributes to named attributes. We can change the design of the objects we are normalizing to, so instead of an object with fixed attributes (Jobstatusdata) we normalize to an object that is an attribute list, or a list of attribute lists. This would allow the views to vary per adapter without adding additional work for each adapter.
I'll share code explaining my proposal.
I'm skeptical. It's easier to normalize and test ruby code than it is to troubleshoot all of this on the frontend in JavaScript.
Do we need to mimic the exact output of each unique adapter's stat command?
activejobs
is already an abstraction of the job information, and the existing view is itself an abstraction of what qstat provides. In this case, "reason" seems like additional data that we could display in the extended view, and maybe I'm not familiar enough with slurm, but the essential point of the message is to tell a user that the job is queued
or queued_held
. I think providing a uniform view across installations is IMHO preferred to adding all sorts of logic to display or hide options, especially since we're going to need to be testing this app on many different environments.
I think we should talk about design and planning for maintainability of this feature before I start coding this in.
It was decided that reason did not need to be added to the initial view.
It has been added to the extended view https://github.com/OSC/ood-activejobs/commit/0f6caf5a04d7fca04965d7f78163540c76c514de
For Slurm only a typical
squeue
call gives...Note that the REASON is given when a job is pending (queued). So this should be a second-class (or very near first-class) citizen when displaying extended attributes about a job.
You can read more about the REASON codes here:
https://slurm.schedmd.com/squeue.html#lbAF