search

OSC / ood-ansible

An ansible role for Open Ondemand
MIT License
30 stars 31 forks source link

Version install logic not as documented #214

Open sjpb opened 1 year ago

sjpb commented 1 year ago

In README#installing-a-specific-version this says:

ondemand_package defaults to latest meaning this will install the latest version on the versioned yum/deb repository. For example, it'll install the latest version, 2.0.20 from the versioned 2.0 yum repo.

We use ondemand_package for the name paramter of the ansible yum so you can speicify a specific version with ondemand-2.0.20 or use the comparison operators ansible supports.

However the rpm install logic shows that to get the latest package, you should use ondemand_package: ondemand, and this is actually the default.

The 2nd para also has some typos and probably needs to be updated for the default of v3 packages now?

sjpb commented 1 year ago

I'd suggest:

ondemand_package can be used to control the version of the rpm/deb package installed. The default, ondemand, will install the latest version available from the relevant repository. You can specify a specific version using e.g. ondemand-3.0.3 or use the comparison operators supported by the name parameter of the ansible yum module.

johrstrom commented 1 year ago

Thank you for the suggestion! pleas feel free to review or add additional comments on #215.