search

OSC / ood-documentation

Documentation for Open OnDemand generated using Sphinx
https://osc.github.io/ood-documentation/latest/
MIT License
8 stars 51 forks source link

Add conn-params link and page with content #815

Closed Oglopf closed 1 year ago

Oglopf commented 1 year ago

Modify this link to include the branch name, and possibly the page this PR modifies:

https://osc.github.io/ood-documentation-test/document-conn-params/

Add your description here Documenting the conn-params pattern.

This still needs a bit of work as I was surprised when working the Rstudio example to notice not all variables were exportet, which I had thought was necessary.

Not a big deal, but I'd like to understand when the export is needed and not before this is done.

┆Issue is synchronized with this Asana task by Unito

johrstrom commented 1 year ago

Not a big deal, but I'd like to understand when the export is needed and not before this is done.

I'm fairly sure you you need to export everything in the before.sh.erb . You can look at the flow here - but script.sh.erb is running in the background (so it's parallel to the main job_script_content.sh that writes the yaml). so it's best to export everything in before.sh.erb because that's synchronous WRT to the script that writes the yaml.

https://github.com/OSC/ood_core/blob/95c4799f1d5bcf0f314e37fd8bd2d53b99edd131/lib/ood_core/batch_connect/template.rb#L305