search

OSC / ood-documentation

Documentation for Open OnDemand generated using Sphinx
https://osc.github.io/ood-documentation/latest/
MIT License
8 stars 48 forks source link

Misconfigured Custom Job Submission Example #939

Open Oglopf opened 4 months ago

Oglopf commented 4 months ago

If you look at the example here: https://osc.github.io/ood-documentation/latest/enable-desktops/custom-job-submission.html#custom-job-submission

It has the cluster attribute set while also providing a submit attribute as well. This is at best redundant and at worst very confusing to new users trying to use this setting. Yank the cluster attr and focus on the submit.

johrstrom commented 4 months ago

I don't think I follow you on this. cluster and submit do very different things, so they're not redundant. I guess I'll have to look at the discourse topic that generated this, but if you look at all of our OSC production applications, we never override the cluster in the submit.yml.erb. It's something you can do for sure, but shouldn't be the default, it should be the exception.