OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer
https://osc.github.io/Open-OnDemand/
MIT License
4 stars 1 forks source link

Dotfiles is broken because when setting a cookie we don't explicitly set the path to / or /pun/sys/files #100

Closed ericfranz closed 8 years ago

ericfranz commented 8 years ago

The result is that when I go to https://websvcs08.osc.edu/pun/sys/files/fs/nfs/17/efranz/ a cookie named dotfiles is created with the path /pun/sys/files/fs/nfs/17/efranz and then when I go to https://websvcs08.osc.edu/pun/sys/files/fs/nfs/17 a separate cookies is created with the path set to /pun/sys/files/fs/nfs/17

If I set disable dotfiles so that this cookie at /pun/sys/files/fs/nfs/17 is false and I disable dotfiles so that the cookie at /pun/sys/files/fs/nfs/17/efranz is false then close both windows, next time I go to my home directory and try to enable dotfiles it immediately disables, preventing me from showing dotfiles. Since both cookies are available, when you set the cookie it modifies the /pun/sys/files/fs/nfs/17/efranz cookie but when you read cookies to see if dotfiles should be enabled it looks at /pun/sys/files/fs/nfs/17 which is false and thats why it can never be enabled.

This is probably the same problem that https://github.com/AweSim-OSC/osc-fileexplorer/issues/97 addresses.

brianmcmichael commented 8 years ago

fixed at https://github.com/OSC/cloudcmd/commit/a77a9035f6b6fe218336d843dc6236c2fcd8c6b5