Download selected files in IE appears to be broken

OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer

https://osc.github.io/Open-OnDemand/

MIT License

4 stars 1 forks source link

Download selected files in IE appears to be broken #105

Closed ericfranz closed 8 years ago

ericfranz commented 8 years ago

User is not prompted to save the files. Perhaps the headers are incorrectly set server-side?

It appears this header is not being set:

Content-Disposition:attachment; filename="desktop.jnlp"

Since we already append ?download to the file URL when downloading them, we can detect this in some express middleware and just set the content disposition header appropriately.

brianmcmichael commented 8 years ago

https://github.com/AweSim-OSC/osc-fileexplorer/pull/106 fixes this for IE currently.

Looking for a solution that will work with MS Edge...

I noticed in Chrome that even after the content disposition is added it's still interpreting it as a Document. This may be the cause of the Edge issue.

resource

brianmcmichael commented 8 years ago

I think we discovered at one point that the files are being downloaded in an iframe.

If that's the case, It may be a good idea to use a new tab instead.

brianmcmichael commented 8 years ago

Appears to be resolved by https://github.com/AweSim-OSC/osc-fileexplorer/pull/106