Fix IE11 icons - Githubissues

OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer

https://osc.github.io/Open-OnDemand/

MIT License

4 stars 1 forks source link

Closed brianmcmichael closed 8 years ago

brianmcmichael commented 8 years ago

Fixes ie11 icons by removing pragma header for HTTPS. See: https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting#im-hosting-fonts-on-my-server-and-icons-dont-show-up
- We may need to later remove no-store from "Cache-Control" headers per the above, but for now it's working without the modification.
Update to latest OSC/cloudcmd

brianmcmichael commented 8 years ago

@ericfranz please review.

Note, the npm install <package> --save option still updates all of the other dependencies as long as they are in the version range specified in the package.json. I'm not sure that there's a way around that short of hardcoding precise version numbers into the package.json of OSC/cloudcmd, which I don't like the idea of.

ericfranz commented 8 years ago

We may need to later remove no-store from "Cache-Control" headers per the above, but for now it's working without the modification.

Why would we need to do this? Can we remove it right now? Does cache busting still work?

brianmcmichael commented 8 years ago

Why would we need to do this?

Can we remove it right now?

Sure. I made the smallest cut to get this working.

Does cache busting still work?

The "Cache-Control" headers are still in place. "Pragma" is part of HTTP/1.0 specification, while "Cache-Control" is HTTP/1.1