search

OSC / ood-fileexplorer

[MOVED] The Open OnDemand File Explorer
https://osc.github.io/Open-OnDemand/
MIT License
4 stars 1 forks source link

Cloud Commander lets you open a basic terminal. Do we want this? #17

Closed ericfranz closed 8 years ago

ericfranz commented 8 years ago

Go to dashboard. Click "Files". Press the backtick key. I have a terminal on websvcs08.osc.edu, and the directory I'm in is the cloud commander app directory.

screen shot 2016-04-08 at 11 01 52 am

If we are keeping this feature, pressing backtick should open the terminal to the directory you are in. But I imagine we don't want to keep this feature. Better to have an "open current directory in terminal" or "open directory in terminal" context menu option to open in wetty.

brianmcmichael commented 8 years ago

No, we don't want this. I removed the option from the menu, but apparently there's a keypress listener still in there. This should be removed since it's accessing websvcs08

brianmcmichael commented 8 years ago

We had done some experimentation with wetty and it is possible to create a route that will 'cd' you into the appropriate directory there, but it hasn't been implemented.

ericfranz commented 8 years ago

Does wetty need modified in order to support this "open directory in terminal" feature?

brianmcmichael commented 8 years ago

OSC shell can be modified to accept a GET param and then use that param to pass a cd command into the ssh request.

It worked for websvcs08, but I'm not sure how it would work when attempting to connect to oakley. (Because of ssh key approval)

brianmcmichael commented 8 years ago

Removed the keypress listeners and disabled the 'console-io' package from running serverside.

https://github.com/AweSim-OSC/osc-fileexplorer/compare/4ae7fc2297cf...031afc505e39